Skip to content

server: fix npe during start vr edge case#10366

Merged
yadvr merged 1 commit intoapache:4.19from
shapeblue:fix-startvr-npe
Mar 18, 2025
Merged

server: fix npe during start vr edge case#10366
yadvr merged 1 commit intoapache:4.19from
shapeblue:fix-startvr-npe

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Feb 11, 2025 •
edited
Loading

Description

DeploymentPlanner.addPod takes long value while
VmInstanceVO.getPodIdToDeployIn returns a Long value which can be null when the VM is never started.

Error seen while doing consecutive VPC restarts with cleanup,

java.lang.NullPointerException
        at com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(NetworkHelperImpl.java:448)
        at com.cloud.network.router.NetworkHelperImpl.startRouters(NetworkHelperImpl.java:384)
        at org.apache.cloudstack.network.router.deployment.RouterDeploymentDefinition.deployVirtualRouter(RouterDeploymentDefinition.java:209)
        at com.cloud.network.element.VpcVirtualRouterElement.prepare(VpcVirtualRouterElement.java:307)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareElement(NetworkOrchestrator.java:1756)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareNic(NetworkOrchestrator.java:2129)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepare(NetworkOrchestrator.java:2056)
        at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1253)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
server: fix npe during start vr edge case
bfe5aa7 
DeploymentPlanner.addPod takes long value while
VmInstanceVO.getPodIdToDeployIn returns a Long value which can be null
when the VM is never started.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.15%. Comparing base (802bf5f) to head (bfe5aa7).
Report is 36 commits behind head on 4.19.

Files with missing lines Patch % Lines
...va/com/cloud/network/router/NetworkHelperImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             4.19   #10366       +/-   ##
===========================================
+ Coverage        0   15.15%   +15.15%     
- Complexity      0    11314    +11314     
===========================================
  Files           0     5413     +5413     
  Lines           0   474671   +474671     
  Branches        0    57891    +57891     
===========================================
+ Hits            0    71941    +71941     
- Misses          0   394683   +394683     
- Partials        0     8047     +8047
Flag Coverage Δ
uitests 4.29% <ø> (?)
unittests 15.87% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 11, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 11, 2025

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 11, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12407

DaanHoogland
DaanHoogland approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 13, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Feb 13, 2025

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Feb 13, 2025

[SF] Trillian test result (tid-12387)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50754 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10366-t12387-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland added this to the 4.19.3 milestone Feb 14, 2025
@shwstppr shwstppr marked this pull request as ready for review February 20, 2025 08:02
@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025
@yadvr yadvr merged commit 89e6b1f into apache:4.19 Mar 18, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Mar 18, 2025
@yadvr yadvr deleted the fix-startvr-npe branch March 18, 2025 03:22
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@shwstppr @dhslove
server: fix npe during start vr edge case (apache#10366)
c7e554f 
DeploymentPlanner.addPod takes long value while
VmInstanceVO.getPodIdToDeployIn returns a Long value which can be null
when the VM is never started.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

component:networking

Projects

ACS 4.20.1
Status: Done

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr @blueorangutan @DaanHoogland @Pearl1594 @yadvr